[PATCH] D16569: Emit line 0 line information for interesting 'orphan' instructions

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 10:09:17 PST 2016

probinson added a comment.

I've asked Wolfgang to run a size experiment.

Can we really have a case where BB will change but there's no label?

Post-call cases...  not as important as top-of-block cases, I think.  Also, harder to detect reliably. Local-value instructions might not be immediately following the call instruction, if the call returns a value that has to be moved somewhere else or there's other post-call state to restore?
I think it's not horrible if post-call local-value instructions end up implicitly attached to the call's source location.

Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.h:246
@@ -245,1 +245,3 @@
+  const MachineBasicBlock *CurBB;
+  bool LastWasCall;
Maybe PrevBB and PrevWasCall, for consistency?


More information about the llvm-commits mailing list