[PATCH] D16440: [ThinLTO] Link in only necessary DICompileUnit operands

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 08:57:51 PST 2016

joker.eph added a comment.

It seems that

> Why aren't these correlated by the metadata ID instead? I.e. !93 instead of !"_ZTSN11xercesc_2_516XMLPlatformUtilsE" in the DISubprogram scope? Then no TypeIdentifierMap would be needed.

I think it is to break cycles. String are a convenient way to break dependencies :)

I discussed with Duncan yesterday, the ultimate plan he had last year seemed to be to reverse all the links: Subprograms would point to the CompileUnit instead of the opposite for instance. And ultimately there wouldn't be a need for the named metadata dbg.cu.


More information about the llvm-commits mailing list