[PATCH] D15774: [PEI] Calculate stack protector frame offset before local stack allocation.

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 04:28:03 PST 2016


rengolin added subscribers: t.p.northover, rengolin.
rengolin added a reviewer: t.p.northover.
rengolin added a comment.

This looks like a simple patch, but I don't claim to understand the original problem, so I'm not sure what we're dealing with here.

@andrew, @t.p.northover, could you guys have a look?


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:634
@@ -659,3 +633,3 @@
   // Make sure that the stack protector comes before the local variables on the
   // stack.
   SmallSet<int, 16> ProtectedObjs;
----------------
This seems to imply that the move down of the code above is good.


Repository:
  rL LLVM

http://reviews.llvm.org/D15774





More information about the llvm-commits mailing list