[PATCH] D16530: [Polly] Introduce MemAccInst helper class; NFC

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 03:32:34 PST 2016

grosser added a comment.

Hi Michael,

I think this patch makes a lot of sense. Unfortunately all these casts make it look rather ugly as they introduce more noise than is actually removed. I just looked quickly at the implementation of CallSite and it seems the implementation is slightly different. Specifically, it does not inherit from instruction, but rather creates a proxy class around the CallInst/InvokeInst. Like this it is possible to add default constructors for CallSite(Invoke Ty) and CallSite(CallTy) that allow for automatic implicit type conversion. Could this be a solution that would allow us to remove the need for explicit casts?



More information about the llvm-commits mailing list