[PATCH] D16540: Avoid almost duplication in .dynamic finalize and write.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 11:28:17 PST 2016

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM. This is a very nice change. Thank you for doing this.

Comment at: ELF/OutputSections.cpp:596
@@ -595,2 +595,3 @@
-  unsigned NumEntries = 0;
+  // Reserve strings
+  if (!Config->RPath.empty())
It is better to describe a bit more detail. Because only this DynamicSection adds strings to DynStrTab, we can compute the size of DynStrTab early in this function, and that helps us to fill DT_STRSZ field in this function.


More information about the llvm-commits mailing list