[PATCH] D16273: [opaque pointer types] CallSite: use getFunctionType() instead of going through PointerType::getElementType.

Eduard Burtescu via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 14:26:58 PST 2016


eddyb added inline comments.

================
Comment at: lib/Target/Mips/Mips16HardFloat.cpp:430
@@ -429,3 +429,1 @@
       } else if (const CallInst *CI = dyn_cast<CallInst>(I)) {
-        const Value* V = CI->getCalledValue();
-        Type* T = nullptr;
----------------
dblaikie wrote:
> This code seems to be going to some efforts to support the possibility that V is null - does that case need to be handled in the new code?
Not as far as I can tell, `getFunctionType()` seems to be guaranteed non-null.
The tests pass, although I'm not sure what kind of coverage LLVM has for the Mips16 (sub?)target.


http://reviews.llvm.org/D16273





More information about the llvm-commits mailing list