[PATCH] D16269: [llvm-readobj][ELF] Teach llvm-readobj to show arch specific ELF section's flags

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 14:11:33 PST 2016


davide added inline comments.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1161
@@ +1160,3 @@
+                          std::end(ElfX86_64SectionFlags));
+      break;
+    }
----------------
atanasyan wrote:
> davide wrote:
> > Missing default case I guess?
> By default we do not need to add any additional flags to the `SectionFlags` container. Is it okay to put the following a bit redundant code here?
> ```
> default:
>   break;
> ```
> 
I'm fine with less code (and happier, in general) but please make sure neither gcc or clang will complain with "non all cases covered in switch statement". 


Repository:
  rL LLVM

http://reviews.llvm.org/D16269





More information about the llvm-commits mailing list