[PATCH] D16249: [DwarfDebug] Don't merge DebugLocEntries if their pieces overlap

[Adrian Prantl via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks!


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:808
@@ -807,1 +807,3 @@
 
+/// \brief If this and Next are describing different pieces of the same
+/// variable, merge them by appending Next's values to the current
----------------
Please move the function to the cpp in a separate NFC commit. It helps with bisection and git blame.

================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:817
@@ +816,3 @@
+    if (Expr->isBitPiece() && NextExpr->isBitPiece() &&
+        !piecesOverlap(Expr, NextExpr)) {
+      addValues(Next.Values);
----------------
This appears to be reasonable to me.

================
Comment at: test/DebugInfo/ARM/PR26163.ll:7
@@ +6,3 @@
+; one has a bit_piece), but it is what is currently being emitted, any
+; change here needs to be intentional, so the test is very specific.
+;
----------------
Sad but true.


http://reviews.llvm.org/D16249