[PATCH] D16015: [PGO] Create the profile data variable before the lowering

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 16:27:45 PST 2016


silvas added a comment.

LGTM with a nit.


================
Comment at: lib/Transforms/Instrumentation/InstrProfiling.cpp:152
@@ +151,3 @@
+    if (FirstProfIncInst != nullptr)
+      getOrCreateRegionCounters(FirstProfIncInst);
+  }
----------------
Cast the result to void to indicate that we are throwing away the return value of this function (i.e. we are only calling it for the side effects).


http://reviews.llvm.org/D16015





More information about the llvm-commits mailing list