[PATCH] D16016: [PGO] IR level instrumentation of indirect call value profiling

[Rong Xu via llvm-commits]

Thanks for the comments. I'll fix them.

-Rong

On Fri, Jan 15, 2016 at 2:23 PM, Betul Buyukkurt <betulb at codeaurora.org> wrote:
> betulb added inline comments.
>
> ================
> Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:345
> @@ +344,3 @@
> +
> +  if (DisableValueProfiling) return;
> +
> ----------------
> The return should be on its own line. clang-format.
>
> ================
> Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:318
> @@ +317,3 @@
> +// Visitor class that finds all indirect call sites.
> +struct GetIndirectCallVisitor : public InstVisitor<GetIndirectCallVisitor> {
> +  std::vector<CallInst *> IndirectCallInsts;
> ----------------
> I do not like the variables to have names like "Get....". IndirectCallSiteVisitor would have been more appropriate.
>
>
> http://reviews.llvm.org/D16016
>
>
>