[llvm] r257935 - PM: Fix an inverted condition in simplifyFunctionCFG

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 13:21:39 PST 2016


Author: bogner
Date: Fri Jan 15 15:21:39 2016
New Revision: 257935

URL: http://llvm.org/viewvc/llvm-project?rev=257935&view=rev
Log:
PM: Fix an inverted condition in simplifyFunctionCFG

I mentioned the issue here in code review way back in September and
was sure we'd fixed it, but apparently we forgot:

  http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150921/301850.html

In any case, as soon as you try to use this pass in anything but the
most basic pipeline everything falls apart. Fix the condition.

Modified:
    llvm/trunk/lib/Transforms/Scalar/SimplifyCFGPass.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/SimplifyCFGPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SimplifyCFGPass.cpp?rev=257935&r1=257934&r2=257935&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/SimplifyCFGPass.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/SimplifyCFGPass.cpp Fri Jan 15 15:21:39 2016
@@ -182,7 +182,7 @@ PreservedAnalyses SimplifyCFGPass::run(F
   auto &TTI = AM->getResult<TargetIRAnalysis>(F);
   auto &AC = AM->getResult<AssumptionAnalysis>(F);
 
-  if (!simplifyFunctionCFG(F, TTI, &AC, BonusInstThreshold))
+  if (simplifyFunctionCFG(F, TTI, &AC, BonusInstThreshold))
     return PreservedAnalyses::none();
 
   return PreservedAnalyses::all();
@@ -236,4 +236,3 @@ llvm::createCFGSimplificationPass(int Th
                                   std::function<bool(const Function &)> Ftor) {
   return new CFGSimplifyPass(Threshold, Ftor);
 }
-




More information about the llvm-commits mailing list