[PATCH] D15035: AMDGPU/SI: Prevent the DAGCombiner from creating setcc with i1 inputs

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 10:55:05 PST 2016


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:512-516
@@ +511,7 @@
+
+  // SimplifySetCC uses this function to determine whether or not it should
+  // create setcc with i1 operands.  We don't want i1 setcc or really any i1
+  // operations.
+  if (VT == MVT::i1)
+    return false;
+
----------------
I think this should only do this for Op == ISD:SETCC.

We probably do want i1 logical operations to use the scalar 64-bit instructions on the results.


http://reviews.llvm.org/D15035





More information about the llvm-commits mailing list