[PATCH] D15034: TargetLowering: Improve handling of (setcc ([sz]ext x) 0, cc) in SimplifySetCC

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:1248
@@ +1247,3 @@
+  if (VT == MVT::i1)
+    return N->isOne();
+
----------------
tstellarAMD wrote:
> arsenm wrote:
> > I think this should be !N->isNull(). If you have a constant true i1, it is -1 for example.
> isOne() and isAllOnesValue() both return true for i1 1.
OK, then it doesn't really matter


http://reviews.llvm.org/D15034