[patch] Fix pr25919

[Keno Fischer via llvm-commits]

It would have been good to reference this discussion in the commit message
of the revert (or even just noting that it is temporarily reverted to fix
breakage), such that those of us who live downstream know whether the API
change is permanent or not.

On Thu, Jan 14, 2016 at 10:07 AM, Michael Zolotukhin via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Hi Rafael,
>
> I temporarily reverted r256105 to unbreak our bots in r257751. Please feel
> free to recommit with a fix.
>
> Thanks,
> Michael
>
> > On Jan 13, 2016, at 7:11 PM, Michael Zolotukhin <mzolotukhin at apple.com>
> wrote:
> >
> > Hi Rafael,
> >
> > We’ve started to hit this assert in our LLVM bootstraps. Do you expect
> this fix to be committed anytime soon, or is it better just to revert for
> now?
> >
> > Thanks,
> > Michael
> >> On Jan 8, 2016, at 3:20 PM, Mikhail Zolotukhin <mzolotukhin at apple.com>
> wrote:
> >>
> >> Hi Rafael,
> >>
> >> I recently hit the same bug while building 483.xalanc from SPEC2006. Do
> you mind reverting the original patch while the fix is under review?
> >>
> >> Thanks,
> >> Michael
> >>
> >>> On Dec 22, 2015, at 7:46 AM, Rafael Espíndola via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
> >>>
> >>> The asserts for checking all uses while the module is being
> >>> materialized found the first problem.
> >>>
> >>> The issues happens when libLTO is trying to set
> >>> LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN. It needs all uses in order to
> >>> produce a valid answer.
> >>>
> >>> The attached patch adds a graceful degradation.
> >>>
> >>> What is done instead in the gold plugin is to check the uses in the
> >>> merged module.
> >>>
> >>> If this degrades quality too much, a solution would be to check the
> >>> uses and add unnamed_addr marks at the end of IRGen. That way
> >>> canBeOmittedFromSymbolTable would not need to run analyzeGlobal at
> >>> all.
> >>>
> >>> Cheers,
> >>> Rafael
> >>> <t.diff>_______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at lists.llvm.org
> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >>
> >
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160114/1288d40c/attachment.html>