[PATCH] D16190: [AVX512] adding AVXVBMI feature flag

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 12:09:09 PST 2016


delena added inline comments.

================
Comment at: lib/Support/Host.cpp:826
@@ -825,2 +825,3 @@
   Features["avx512vl"] = HasLeaf7 && ((EBX >> 31) & 1) && HasAVX512Save;
+  Features["avx512VBMI"] = HasLeaf7 && ((ECX >> 1) & 1) && HasAVX512Save;
 
----------------
please take lower case avx512vbmi

================
Comment at: lib/Target/X86/X86.td:135
@@ +134,3 @@
+def FeatureVBMI     : SubtargetFeature<"avx512vbmi", "HasVBMI", "true",
+                      "Enable AVX-512 Byte and Word Instructions",
+                                      [FeatureAVX512]>;
----------------
The string is copied from the prev case.

================
Comment at: lib/Target/X86/X86InstrInfo.td:798
@@ -797,2 +797,3 @@
 def HasBMI2      : Predicate<"Subtarget->hasBMI2()">;
+def HasVBMI      : Predicate<"!Subtarget->hasVBMI()">;
 def HasRTM       : Predicate<"Subtarget->hasRTM()">;
----------------
remove !


http://reviews.llvm.org/D16190





More information about the llvm-commits mailing list