[PATCH] D16193: [ELF][MIPS] Ignore 'hint' relocations like R_MIPS_JALR in the `scanRelocs` method

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 11:03:46 PST 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Writer.cpp:215
@@ -214,1 +214,3 @@
 
+    if (Target->isHintReloc(Type))
+      continue;
----------------
I'd be good to add a brief comment here as well, saying that we can ignore hint relocations because they are for optional optimizations.


Repository:
  rL LLVM

http://reviews.llvm.org/D16193





More information about the llvm-commits mailing list