[PATCH] D15281: [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline

Bradley Smith via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 05:32:30 PST 2016


bsmith added inline comments.

================
Comment at: lib/Target/ARM/ARMISelDAGToDAG.cpp:3765
@@ +3764,3 @@
+      Flags = Flags.drop_front(3);
+      if (Flags.startswith("_"))
+        Flags = Flags.drop_front();
----------------
t.p.northover wrote:
> Won't this allow "basepri_maxns"? Seems a bit inconsistent with the others.
It will reconstruct Reg = basepri, Flags = max{_ns,} into Reg = basepri_max, Flags = {ns,}, the call to getMClassRegisterMask afterwards will check whether or not the ns flags are allowed.


Repository:
  rL LLVM

http://reviews.llvm.org/D15281





More information about the llvm-commits mailing list