[compiler-rt] r257686 - With COMPILER_RT_INCLUDE_TESTS turned ON and in a cross compiling

[Hans Wennborg via llvm-commits]

On Wed, Jan 13, 2016 at 2:09 PM, Sumanth Gundapaneni via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: sgundapa
> Date: Wed Jan 13 16:09:47 2016
> New Revision: 257686
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257686&view=rev
> Log:
> With COMPILER_RT_INCLUDE_TESTS turned ON and in a cross compiling
> environment, the unit tests fail to link. This patch does the following changes
>
>>Rename COMPILER_RT_TEST_CFLAGS to COMPILER_RT_UNITTEST_CFLAGS to reflect the
> way it's used.
>>Add COMPILER_RT_TEST_COMPILER_CFLAGS to COMPILER_RT_UNITTEST_CFLAGS so that
> cross-compiler would be able to build/compile the unit tests
>>Add COMPILER_RT_UNITTEST_LINKFLAGS to COMPILER_RT_UNITTEST_CFLAGS so that
> cross-compiler would be able to link the unit tests (if needed)
>
> Differential Revision:http://reviews.llvm.org/D15082

I believe this is causing failures on Chromium's buildbots. For
example: https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan/builds/4231/steps/gclient%20runhooks/logs/stdio

-- Compiler-RT supported architectures: i386;x86_64
CMake Error at cmake/Modules/AddCompilerRT.cmake:170 (string):
  string sub-command REPLACE requires at least four arguments.
Call Stack (most recent call first):
  lib/CMakeLists.txt:4 (include)