[llvm] r257558 - Use utostr rather than std::to_string

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 21:32:28 PST 2016


Chould this be Twine(VarSize) instead of utostr since the Assert function
can take a Twine? Otherwise this is string concatenation before the call.

On Tue, Jan 12, 2016 at 5:26 PM, Keno Fischer via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: kfischer
> Date: Tue Jan 12 19:26:57 2016
> New Revision: 257558
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257558&view=rev
> Log:
> Use utostr rather than std::to_string
>
> Looks like std::to_string is not available for Android. Hopefully
> this fixes the bot.
>
> Modified:
>     llvm/trunk/lib/IR/Verifier.cpp
>
> Modified: llvm/trunk/lib/IR/Verifier.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Verifier.cpp?rev=257558&r1=257557&r2=257558&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/IR/Verifier.cpp (original)
> +++ llvm/trunk/lib/IR/Verifier.cpp Tue Jan 12 19:26:57 2016
> @@ -4155,9 +4155,9 @@ void Verifier::verifyDIExpression(const
>      // argument. Doing this in the general case would require looking
> through
>      // any dereferences that may be in the expression.
>      Assert(ArgumentTypeSizeInBits == VarSize,
> -           "size of passed value (" +
> std::to_string(ArgumentTypeSizeInBits) +
> +           "size of passed value (" + utostr(ArgumentTypeSizeInBits) +
>                 ") does not match size of declared variable (" +
> -               std::to_string(VarSize) + ")",
> +               utostr(VarSize) + ")",
>             &I, Arg, V, V->getType(), E);
>    } else if (E->getElement(0) == dwarf::DW_OP_deref) {
>      Assert(ArgumentTypeSizeInBits ==
> M->getDataLayout().getPointerSizeInBits(),
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160112/9876816a/attachment.html>


More information about the llvm-commits mailing list