[PATCH] D16114: [llvm-readobj][ELF] Teach llvm-readobj to show dynamic relocation in REL format

[Davide Italiano via llvm-commits]

davide added inline comments.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:110
@@ -108,2 +109,3 @@
   void printRelocation(Elf_Rela Rel, const Elf_Shdr *SymTab);
+  void printDynamicRelocation(Elf_Rela Rel);
   void printValue(uint64_t Type, uint64_t Value);
----------------
Actually, this is out of order.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:955
@@ +954,3 @@
+      break;
+    case ELF::DT_RELSZ:
+      DynRelRegion.Size = Dyn.getVal();
----------------
Ditto.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1029
@@ +1028,3 @@
+template <typename REL>
+const REL *ELFDumper<ELFT>::dyn_rela_begin(const DynRegionInfo &Region) {
+  if (Region.Size && Region.EntSize != sizeof(REL))
----------------
Can you use 'RELA' as typename? (given you're dealing with rela(s))


Repository:
  rL LLVM

http://reviews.llvm.org/D16114