[PATCH] D16110: [Power9] Implement new vsx instructions: quad-precision move, fp-arithmetic

[Nemanja Ivanovic via llvm-commits]

nemanjai added a comment.

Overall, is there a reason for the placement of these new definitions? It seems logical that the new definitions appear at the end of what we have so far (new features at the end of the features already defined, new instructions at the end of the file, etc.).
Of course, if there's a good reason to keep the placement here, so be it. However, we should make sure the placement makes sense.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:1244
@@ +1243,3 @@
+  // TODO: Add intrinsic support, or map to llvm instruction
+  class X1<bits<6> opcode, bits<10> xo, string opc>
+    : XForm_1<opcode, xo, (outs vrrc:$vT), (ins vrrc:$vA, vrrc:$vB),
----------------
nemanjai wrote:
> Same comment about the name as above.
Almost forgot, I think defining classes such as these is fine, but they should have a "pattern" parameter. We don't have a code-gen pattern now, but once we want to generate these, we will.


http://reviews.llvm.org/D16110