[PATCH] D15772: [mips] Macros for [d]div[u],[d]rem[u]

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 06:49:45 PST 2016


dsanders requested changes to this revision.
dsanders added a comment.
This revision now requires changes to proceed.

The code for div and rem should be almost identical (one uses mflo, the other mfhi). Could you fold the duplicate implementations together?

Also, could you separate out the addition of the immediate cases from the addition of rem? Doing this in two patches will make it a bit easier to review.


http://reviews.llvm.org/D15772





More information about the llvm-commits mailing list