[PATCH] D15950: [ARM] Fix several state persistence bugs

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 05:12:17 PST 2016


rengolin added a comment.

Apart from the small comment, this looks good to me.


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1068
@@ +1067,3 @@
+  // do the same here
+  getAssembler().setELFHeaderEFlags(ELF::EF_ARM_EABI_VER5);
+}
----------------
Can't this be changed by a command line flag? Shouldn't we clear based on that?


http://reviews.llvm.org/D15950





More information about the llvm-commits mailing list