[PATCH] D15887: [Power9] Implement new vector permute, count zero instructions

[Nemanja Ivanovic via llvm-commits]

nemanjai added inline comments.

================
Comment at: lib/Target/PowerPC/PPCInstrAltivec.td:1217
@@ +1216,3 @@
+
+def HasP9Altivec : Predicate<"PPCSubTarget->hasP9Altivec()">;
+let Predicates = [HasP9Altivec] in {
----------------
cycheng wrote:
> nemanjai wrote:
> > Since P9 has fewer optional features, do we need P9Altivec, P9Vector, etc.? Or perhaps we would like a single predicate and a single feature that will give us everything? I suppose that AES and DFP are still optional, but any additions therein can use the P9 predicate along with the respective predicate.
> Agree. By the way, how can I know an instruction is optional instruction?
The text "Category:" followed by the name of the category will be part of the instruction description or the section of the ISA. This is of course very prevalent in all versions of Power ISA up to and including 2.07. It is mostly absent from ISA 3.0.


http://reviews.llvm.org/D15887