[PATCH] D16084: [ELF][MIPS] Prevent substitution of _gp_disp symbol

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Driver.cpp:308
@@ -307,2 +307,3 @@
     // On MIPS O32 ABI, _gp_disp is a magic symbol designates offset between
     // start of function and gp pointer into GOT.
+    Config->MipsGpDisp = Symtab.addIgnoredStrong("_gp_disp");
----------------
Can you add a comment on why you are using "Strong" as you described before?

================
Comment at: test/ELF/Inputs/mips-gp-disp-def.s:1
@@ +1,2 @@
+  .data
+  .globl XXXXXXXX
----------------
Please add a comment why we are doing this (that we can't create a shared object file containing the special symbol.)


Repository:
  rL LLVM

http://reviews.llvm.org/D16084