[PATCH] D16083: [bugpoint] Teach bugpoint to reduce MDNodes

Keno Fischer via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 15:06:46 PST 2016


>
> Does bugpoint look for any crash or does it look at the backtrace?
>

It only looks for a crash of any kind.


>
>
>
> > I think we'd have more luck with something that understood the
> > structure of the graph, at least at a high-level.
> >
> > I've heard Adrian and Pete's ideas on that in the past, maybe they
> > can share here?
>
> It is true that blindly hacking at MDNodes can leave us with metadata that
> satisfies the verifier but is corrupt enough to crash the backend. This
> means that the reduced testcase will not be very useful once the bug has
> been fixed. That said, I’m leaning towards that this should be an incentive
> to improve the verifier. We can still add smarter simplifications that run
> before this, such as replacing type definitions with forward declarations
> and the like
>

It sounds like we're essentially all in agreement then. If we're worried
about introducing corruptions, how about we guard this reduction behind a
flag for now (disabled by default), such that those who know about the
caveats can start playing with it and filing any issues for cases that need
to be added to the Verifier.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160112/c2e12784/attachment.html>


More information about the llvm-commits mailing list