[PATCH] D16010: AMDGPU: Emit note directive for HSA even if there are no functions

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 13:57:01 PST 2016


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

This is fine. You should probably clean up getIsaVersion. It appears to be just used as a tag in the object so it doesn't really need a subtarget feature, you could just have a static version that returns a number.

-eric


http://reviews.llvm.org/D16010





More information about the llvm-commits mailing list