[PATCH] D16070: [asan] Optionally print reproducer cmdline in ASan reports.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 12:52:02 PST 2016


kcc added a comment.

Will this link on non-linux? 
You've inserted a call to GetArgsAndEnv into the main path, while GetArgsAndEnv remains in linux-specific code.


================
Comment at: test/asan/TestCases/Posix/print_cmdline.cc:5
@@ +4,3 @@
+//
+// RUN: env not %run %t-exe 2>&1 | FileCheck %s
+// RUN: %env_asan_opts=print_cmdline=false not %run %t-exe 2>&1 | FileCheck %s --check-prefix CHECK-DONT-PRINT
----------------
Why not use the same CHECK prefix for the first two lines? 


http://reviews.llvm.org/D16070





More information about the llvm-commits mailing list