[PATCH] D16043: Ensure -mcpu=xscale works for arm targets

Dimitry Andric via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 10 23:58:19 PST 2016


dim created this revision.
dim added reviewers: rengolin, t.p.northover.
dim added subscribers: andrew, llvm-commits.
Herald added subscribers: rengolin, aemerson.

At some point between 3.7.1 and 3.8.0 (current trunk), for arm targets,
the `-mcpu` option got broken, in the sense that it no longer accepts
`-mcpu=xscale` as an option.

I am unsure what the exact cause is, but it looks like adding "v5e" as a
SUB_ARCH in ARMTargetParser.def helps.  This was submitted by @andrew.

http://reviews.llvm.org/D16043

Files:
  include/llvm/Support/ARMTargetParser.def

Index: include/llvm/Support/ARMTargetParser.def
===================================================================
--- include/llvm/Support/ARMTargetParser.def
+++ include/llvm/Support/ARMTargetParser.def
@@ -96,7 +96,7 @@
           FK_NONE, AEK_NONE)
 ARM_ARCH("iwmmxt2", AK_IWMMXT2, "iwmmxt2", "", ARMBuildAttrs::CPUArch::v5TE,
           FK_NONE, AEK_NONE)
-ARM_ARCH("xscale", AK_XSCALE, "xscale", "", ARMBuildAttrs::CPUArch::v5TE,
+ARM_ARCH("xscale", AK_XSCALE, "xscale", "v5e", ARMBuildAttrs::CPUArch::v5TE,
           FK_NONE, AEK_NONE)
 ARM_ARCH("armv7s", AK_ARMV7S, "7-S", "v7s", ARMBuildAttrs::CPUArch::v7,
           FK_NEON_VFPV4, AEK_DSP)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16043.44433.patch
Type: text/x-patch
Size: 653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160111/9886ef4b/attachment.bin>


More information about the llvm-commits mailing list