[PATCH] D16010: AMDGPU: Emit note directive for HSA even if there are no functions

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 16:38:54 PST 2016


echristo added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.h:90
@@ +89,3 @@
+    // Ideally this would be property of the TargetMachine.
+    return Subtarget.getIsaVersion();
+  }
----------------
This is pretty gross. Why not just move the variable to the TargetMachine or have a function that's part of the target machine that looks up ISA version based on... whatever it is it's based on? :)


http://reviews.llvm.org/D16010





More information about the llvm-commits mailing list