[PATCH] D15950: [ARM] Fix several state persistence bugs

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 01:38:48 PST 2016


rengolin added reviewers: t.p.northover, asl.
rengolin added a comment.

Please, add comments to the reset methods, since they're all closely named.

Also, write up a better commit message, to explain what kind of bugs were you seeing.

Finally, the test, being a simple pass/fail, could also have some longer explanation of what you're not expecting to see here. This could help people later when they find bugs on that test for unrelated changes.


http://reviews.llvm.org/D15950





More information about the llvm-commits mailing list