[PATCH] D15876: [llvm-symbolizer] Print out non-address lines verbatim.

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 15:57:08 PST 2016


aizatsky added a comment.

thanks. submitting.


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:100
@@ -104,2 +99,3 @@
+  const char *pos = InputString.data();
   if (strncmp(pos, kDataCmd, strlen(kDataCmd)) == 0) {
     IsData = true;
----------------
samsonov wrote:
> So, once we have `StringRef`, let's use its methods instead of a C string functions.
> We have a bunch of them: `startswith`, `drop_front`, `ltrim`, `find_first_not_of` etc.
> This can be done in a follow-up commit, but please do so.
I suggest we do this later. I don't see a point in this rewrite now.


http://reviews.llvm.org/D15876





More information about the llvm-commits mailing list