[PATCH] D15961: [WinEH] Verify unwind edges against EH pad tree

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 14:58:25 PST 2016


majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/IR/Verifier.cpp:2953
@@ +2952,3 @@
+    } else if (auto *CSI = dyn_cast<CatchSwitchInst>(TI)) {
+      FromPad = CSI->getParentPad();
+    } else {
----------------
Would this be the same as `FromPad = CSI;` ?  I'm not advocating one form over the other, just curious for my own edification.  If I understand correctly, it would also imply that a catchswitch cannot unwind to itself.


http://reviews.llvm.org/D15961





More information about the llvm-commits mailing list