[PATCH] D15594: Track whether all relocations in a section are implicit, and don't emit them in that case

[Lang Hames via llvm-commits]

lhames accepted this revision.
lhames added a reviewer: lhames.
lhames added a comment.
This revision is now accepted and ready to land.

Apart from that, LGTM. Thanks Pete!


================
Comment at: lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h:172
@@ -172,1 +171,3 @@
+                                          SectionAttr &sectionAttrs,
+                                          bool &allRelocsCanBeImplicit);
 
----------------
Maybe "relocsToDefinedCanBeImplicit"? Either way I think there should be a clear comment on the field in the struct definition below.

================
Comment at: lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp:63
@@ -61,2 +62,3 @@
   uint16_t                  alignment;
+  bool                      allRelocsCanBeImplicit;
   std::vector<AtomInfo>     atomsAndOffsets;
----------------
We should have a comment explaining what this field implies when parsing and writing out a section.


http://reviews.llvm.org/D15594