[PATCH] D15964: Add a comment for AMDGPU relocateOne().

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 11:59:27 PST 2016


ruiu created this revision.
ruiu added a reviewer: tstellarAMD.
ruiu added a subscriber: llvm-commits.

http://reviews.llvm.org/D15964

Files:
  ELF/Target.cpp

Index: ELF/Target.cpp
===================================================================
--- ELF/Target.cpp
+++ ELF/Target.cpp
@@ -1359,6 +1359,10 @@
   return false;
 }
 
+// Implementing relocations for AMDGPU is low priority since most
+// programs don't use relocations now. Thus, this function is not
+// actually called (relocateOne is called for each relocation).
+// That's why the AMDGPU port works without implementing this function.
 void AMDGPUTargetInfo::relocateOne(uint8_t *Loc, uint8_t *BufEnd, uint32_t Type,
                                    uint64_t P, uint64_t SA, uint64_t ZA,
                                    uint8_t *PairedLoc) const {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15964.44243.patch
Type: text/x-patch
Size: 665 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160107/6aedb491/attachment.bin>


More information about the llvm-commits mailing list