[PATCH] D15941: [WebAssembly] Support combining GEP and FrameIndex offsets in memory operand offset field

[Dan Gohman via llvm-commits]

sunfish accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/Target/WebAssembly/WebAssemblyRegisterInfo.cpp:72
@@ +71,3 @@
+
+    if (Offset > std::numeric_limits<uint32_t>::max()) {
+      // If this happens the program is invalid, but better to error here than
----------------
It seems like Offset should be an unsigned type, or casted to one, for this comparison, so that we catch negative Offset values too.


http://reviews.llvm.org/D15941