[test-suite] r256997 - tools/CMakeLists: Add an explanation on why we use custom rules

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 15:37:23 PST 2016


Author: matze
Date: Wed Jan  6 17:37:22 2016
New Revision: 256997

URL: http://llvm.org/viewvc/llvm-project?rev=256997&view=rev
Log:
tools/CMakeLists: Add an explanation on why we use custom rules

Modified:
    test-suite/trunk/tools/CMakeLists.txt

Modified: test-suite/trunk/tools/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/tools/CMakeLists.txt?rev=256997&r1=256996&r2=256997&view=diff
==============================================================================
--- test-suite/trunk/tools/CMakeLists.txt (original)
+++ test-suite/trunk/tools/CMakeLists.txt Wed Jan  6 17:37:22 2016
@@ -1,6 +1,12 @@
 add_executable(timeit-target timeit.c)
 
 # FIXME: Replicate Makefile.tools's logic for determining whether to use fpcmp/fpcmp.sh
+
+# Note that we have to compile fpcmp and timeit for the host machine even when
+# cross compiling to a different target. We use custom rules doing "cc file.c"
+# as an ad-hoc solution for now. A proper solution would probably be based on
+# ExternalProject_Add(); See also http://reviews.llvm.org/D15004
+
 set(TEST_SUITE_HOST_CC "cc" CACHE STRING "C compiler targetting the host")
 mark_as_advanced(TEST_SUITE_HOST_CC)
 add_custom_target(fpcmp




More information about the llvm-commits mailing list