[PATCH] D15876: [llvm-symbolizer] Print out non-address lines verbatim.

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 10:20:51 PST 2016


samsonov added a comment.

Out of curiosity, why do you need this? What is addr2line behavior for non-address lines?


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:93
@@ -92,3 +92,3 @@
 static bool parseCommand(bool &IsData, std::string &ModuleName,
-                         uint64_t &ModuleOffset) {
+                         uint64_t &ModuleOffset, char *InputString) {
   const char *kDataCmd = "DATA ";
----------------
Argument should at least be `const char*`, and go before output parameters. Or make it a StringRef.


http://reviews.llvm.org/D15876





More information about the llvm-commits mailing list