[PATCH] D15919: Revert "GlobalsAA: Take advantage of ArgMemOnly, InaccessibleMemOnly and InaccessibleMemOrArgMemOnly attributes"

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 05:14:21 PST 2016


deadalnix added inline comments.

================
Comment at: lib/Analysis/GlobalsModRef.cpp:388
@@ -387,3 +379,2 @@
-        }
       }
     } else if (ICmpInst *ICI = dyn_cast<ICmpInst>(I)) {
----------------
vaivaswatha wrote:
> In my opinion, this part can actually stay. I'll let the others decide though.
Even if we want to go that road, I think it makes sense to do a clean revert and then reintroduce the changes that makes sense in their own diifs, with their own tests.


http://reviews.llvm.org/D15919





More information about the llvm-commits mailing list