[PATCH] D15696: [ThinLTO] Enable in-place symbol changes for exporting module

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/Linker/LinkModules.cpp:130
@@ +129,3 @@
+      : Mover(Mover), SrcM(SrcM), Flags(Flags), ImportIndex(Index),
+        FunctionsToImport(FunctionsToImport), ValIDToTempMDMap(ValIDToTempMDMap) {
+    assert((ImportIndex || !FunctionsToImport) &&
----------------
joker.eph wrote:
> clang-format
I did (just tried again) and it doesn't touch this. What looks wrong?

================
Comment at: lib/Linker/LinkModules.cpp:191
@@ -133,1 +190,3 @@
+  GlobalValue::LinkageTypes getLinkage(const GlobalValue *SGV);
+
   /// Process globals so that they can be used in ThinLTO. This includes
----------------
joker.eph wrote:
> Why was this declaration moved? Keeping it after `processGlobalForThinLTO` allows for a smaller diff.
I think I removed this then put it back and inadvertently moved it. Will put it back.


http://reviews.llvm.org/D15696