[PATCH] D15873: AMDGPU: Implement readcyclecounter

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 15:38:15 PST 2016


arsenm added inline comments.

================
Comment at: test/CodeGen/AMDGPU/readcyclecounter.ll:7
@@ +6,3 @@
+; GCN-LABEL: {{^}}test_readcyclecounter:
+; GCN: s_memtime s{{\[[0-9]+:[0-9]+\]}}
+; GCN: buffer_store_dwordx2
----------------
nhaehnle wrote:
> s_memtime needs a s_waitcnt, right? Makes sense to check for that here, but not a big deal either way.
That would surprise me if it does need it since it isn't actually a load. This should probably be special cased to not require a waitcnt


http://reviews.llvm.org/D15873





More information about the llvm-commits mailing list