[PATCH] D15784: Enable 2 warnings on MSVC, turn on StringPooling & intrinsic functions

[Aaron Ballman via llvm-commits]

aaron.ballman added a comment.

In http://reviews.llvm.org/D15784#318390, @ariccio wrote:

> Added stats. See inline comments.


Thank you for doing the analysis, this is very helpful information! From looking at the results, it appears that this is only a win for debug builds; with the other builds, the changes are negligible.

Release

| File         | Without Patch | With Patch | Change |
| ------------ | ------------- | ---------- | ------ |
| clang.exe    | 34,474,496    | 34,473,984 | 512b   |
| libclang.dll | 27,575,296    | 27,575,296 | 0      |
| LTO.dll      | 23,004,160    | 23,004,160 | 0      |
| llc.exe      | 19,832,320    | 19,832,320 | 0      |
| opt.exe      | 19,069,952    | 19,069,952 | 0      |

Debug

| File         | Without Patch | With Patch  | Change |
| ------------ | ------------- | ----------- | ------ |
| clang.exe    | 107,311,104   | 102,623,232 | 4.4mb  |
| libclang.dll | 90,830,336    | 87,031,808  | 3.6mb  |
| LTO.dll      | 59,970,560    | 57,349,120  | 2.5mb  |
| llc.exe      | 52,477,440    | 50,145,792  | 2.2mb  |
| opt.exe      | 55,005,184    | 52,358,144  | 2.5mb  |

I'm not certain that the /GF flag is worth turning on, given that this flag can increase the number of addressable sections, and we've had to work to stay under the /bigobj limit in the past. If it didn't affect /bigobj, I would have no problem turning it on.


http://reviews.llvm.org/D15784