[PATCH] D15842: [WinEH] Verify catchswitch handlers

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 1 23:18:05 PST 2016


majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/IR/Verifier.cpp:3084
@@ -3083,1 +3083,3 @@
 
+  Assert(CatchSwitch.getNumHandlers(),
+         "CatchSwitchInst cannot have empty handler list", &CatchSwitch);
----------------
Might be good to have it as `CatchSwitch.getNumHandlers() != 0` to make it more explicit.  Either way works for me.


http://reviews.llvm.org/D15842





More information about the llvm-commits mailing list