[PATCH] D14256: [AsmParser] Backends can parameterize ASM tokenization.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 31 00:50:44 PST 2015

And here Colin is yet another commit you have landed without review.

You seem to have been landing multiple MC changes without getting any
review or comment from anyone else working on MC despite mailing them out
for pre-commit review. What on earth is going on here?

Looking at the diff, this also seems to effectively revert multiple changes
 made to the AsmParser code in the last few months. I assume you're trying
to upstream patches from some internal branch, but you *really must*
actually merge the trunk changes in!

Yet again, please revert this, and every other patch dependent on it if
necessary, and every other patch you are landing outside of Hexagon without
bothering to respect our code review process.


On Sun, Nov 8, 2015 at 8:15 PM Colin LeMahieu via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> colinl abandoned this revision.
> colinl added a comment.
> 252439
> Repository:
>   rL LLVM
> http://reviews.llvm.org/D14256
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151231/fc09a40c/attachment.html>

More information about the llvm-commits mailing list