[PATCH] D14257: [AsmParser] Generalize matching for grammars without mnemonic-lead statements.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 31 00:26:51 PST 2015

I don't care when it went in Craig, it went in without any review at all.

Colin, please revert this immediately and ping the thread for a proper
review. You've been around long enough to know that this kind of behavior
(posting for review, clearly having concerns about it, and then landing
without any review happening) is completely unacceptable.

On Tue, Dec 29, 2015 at 8:19 PM Craig Topper via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> craig.topper added a comment.
> I know this revision went in a while ago, but this seems like a really
> terribly performing option for Hexagon. It does a linear scan through the
> entire match table (which at the time of this writing is 2160 entries) for
> any instruction that starts with a non-token. There appear to be about
> ~1500 such mnemonic-less entries in table so about 3/4 of the entire table.
> Repository:
>   rL LLVM
> http://reviews.llvm.org/D14257
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151231/042c18d6/attachment.html>

More information about the llvm-commits mailing list