[PATCH] D15830: [PGO] Enable building compiler-rt profile support library on Windows

Nathan Slingerland via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 30 15:37:36 PST 2015

slingn added a comment.

mmap-windows.c gets #included directly in GCDAProfiling.c since the compatibility mmap()/msync()/flock() functions are not used anywhere else (they are static).

I agree it is a bit odd - and CMake won't properly detect changes to mmap-windows.c the way things are now. Perhaps it would be better to mark them with COMPILER_RT_VISIBILITY (and not static).


More information about the llvm-commits mailing list