[PATCH] D15830: [PGO] Enable building compiler-rt profile support library on Windows

David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 30 14:51:05 PST 2015


davidxl added inline comments.

================
Comment at: lib/profile/mmap-windows.c:2
@@ +1,3 @@
+/*
+ * This code is derived from uClibc (original license follows).
+ * https://git.uclibc.org/uClibc/tree/utils/mmap-windows.c
----------------
This file needs to be re-licensed and redistributed under LLVM* license.  need to talk to the contributor of the file and get the permission.



================
Comment at: lib/profile/mmap-windows.c:124
@@ +123,3 @@
+
+  // Exactly one of MS_ASYNC or MS_SYNC must be specified.
+  switch (flags & (MS_ASYNC | MS_SYNC)) {
----------------
better use C style comments -- also in many other places.


http://reviews.llvm.org/D15830





More information about the llvm-commits mailing list