[PATCH] D15801: Improve the documentation on committing code reviewed on Phabricator to trunk.
Paul Robinson via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 30 11:28:16 PST 2015
probinson added a comment.
In http://reviews.llvm.org/D15801#317952, @delcypher wrote:
> In http://reviews.llvm.org/D15801#317794, @probinson wrote:
> > Did you also want to add a pointer to the Phab page on the markup language? It isn't necessarily obvious that Phabricator is actually a separate project with its own documentation; the code-review pages don't have any "help" links for example. (The only docs I was ever able to find were pretty generic "code reviews are good for you" pages, never did find any UI help of any kind.)
> This is out of scope for what this commit is trying to address but I could certainly address it in a later commit. There doesn't seem to be a relevant section for this sort of information. Perhaps there should be a **Tips on usiing Phabricator** section or something?
The "Reviewing code with Phabricator" section seems like it would be a reasonable place to link to the markup description. Or a new "tips" section could work too. Deferring that to a followup is fine.
Current revision LGTM.
More information about the llvm-commits