[PATCH] D15746: Normalize the features string in SubtargetFeatures::getFeatureBits

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 30 02:00:33 PST 2015

mkuper added a comment.

The changes to SubtargetFeatures::ToggleFeature and SubtargetFeatures::ApplyFeatureFlag LGTM, thanks for making them.

As to the actual patch, I'm not sure whether normalizing like this is really the desired behavior or not.
I'm not against it, as such, but I'd like to hear Eric's opinion.


More information about the llvm-commits mailing list