[PATCH] Teach CMake build system to run lit's own test suite

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 28 01:45:33 PST 2015


Jonathan Roelofs recently remarked that we aren't running lit's (aka
llvm-lit) own test suite as part of the ``check-all`` target.

The attached patch is a first attempt at fixing this by

* Adding a ``check-lit`` target which runs lit's test suite.
* Due to the implementation the tests are implicitly run as part of
``make check-all``.

Two issues may need addressing:

1. Is this the right implementation? One could argue that lit's own
test suite should be run before testing any of LLVM with lit. This
implementation seemed simpler though. If we do decide to implement
this differently we need to decide if running ``check-lit`` is a
prerequisite of only ``check-all`` or all of the other ``check-*``
targets (this might be annoying when developing because the lit test
suite is slow due to running the timeout tests).

2. I'm concerned that this may break several build bots. Although the
lit test suite is supposed to be portable I'm not sure if it has been
run on all the platforms that we build LLVM on. I'm wondering if we
should give owners of the buildbot slaves a heads up before this gets
committed. Also if we want all features of lit to be tested the owners
will need to install the ``psutil`` python module which is currently
required to use the newly added ``--timeout=`` feature.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Teach-the-CMake-build-system-to-run-lit-s-tests.-The.patch
Type: text/x-patch
Size: 2918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151228/680b27f8/attachment.bin>

More information about the llvm-commits mailing list